Add OpenCensus bridge internal package #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:bridges
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
paivagustavo,
pellared and
XSAM
as code owners
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #2146 +/- ##
=======================================
- Coverage 72.2% 72.2% -0.1%
=======================================
Files 170 176 +6
Lines 12076 12088 +12
=======================================
+ Hits 8724 8731 +7
- Misses 3111 3115 +4
- Partials 241 242 +1
|
|
I'm going to pull the addition of tests out of this and put it in a follow on PR to accelerate the review of this. This PR will not only block the addition of tests PR, but also blocks the refactor of the integration tests into a |
Aneurysm9
approved these changes
Jul 29, 2021
jmacd
approved these changes
Aug 5, 2021
XSAM
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This move is to enable access to internal types in a planned
testmodule (see #2144 for more information).The only functional change is in the error handling. The global error handler cannot be reset multiple times (#2140) so a local variable is used get around this. Additionally, the conversion of the span start options now returns an error instead of trying to formulate a error with the context of the span it is being called for.
In addition to moving the implementation to an internal package this adds tests for all the conversions and methods.Unit tests for the conversion functions and types methods will be added in a follow on PR.